Repository navigation
Watch app: restore G7SensorKit's framework reference - #2652
Open
jeremybarnum wants to merge 2 commits into
Open
jeremybarnum wants to merge 2 commits into
jeremybarnum wants to merge 2 commits into
Conversation
LoopKit#2645 deleted the watch app's G7SensorKit file reference and two of its build entries while moving files into LoopCore. The watch app still imports G7SensorKit (WatchDeviceManagers.swift), so a build without an already-built G7SensorKit fails with "Unable to resolve module dependency: 'G7SensorKit'". This puts back the five lines as they were before LoopKit#2645. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…efinition LoopKit#2645 also added entries for OmnipodKit, RileyLinkKit and RileyLinkBLEKit to the watch app's framework list, carried over from Sport Mode's watch app, with no definitions behind them. They refer to nothing, and the stock watch app uses none of those kits; this removes them. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
|
@ps2 This fix should be brought in ASAP as it breaks loop-next-dev when doing a clean build |
Author
Some additional cleanups now pushed that will help resolve this in a principled way. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#2645 deleted the watch app's G7SensorKit file reference and two of its build entries while moving files into LoopCore. The watch app still imports G7SensorKit (
WatchDeviceManagers.swift), so a build without an already-built G7SensorKit fails with "Unable to resolve module dependency: 'G7SensorKit'". This puts back the five lines as they were before #2645.It also removes three entries #2645 added to the watch app's framework list, for OmnipodKit, RileyLinkKit and RileyLinkBLEKit. They came from Sport Mode's watch app and have no definitions behind them, so they refer to nothing.
LoopWorkspace's next-dev still pins Loop from before #2645, so it builds today; it would break at the next bump of Loop.
🤖 Generated with Claude Code