Repository navigation
Show the loop as open while a manual temp basal is running - #2649
Merged
Merged
Conversation
A manual temp basal stops automatic dosing, but the loop icon stayed closed and went stale and red while it ran, as if the loop were failing. Treat automation as active only when Closed Loop is on and no manual temp basal is running, for the status HUD, the loop status popup, the widget and Live Activity context and the watch.
…nning A manual temp basal blocks enacting, so lastLoopCompleted stops advancing and the 20/40/60/120 minute Loop Failure notifications fired even though the loop was still running. While a manual temp basal runs, schedule them from each loop cycle instead, so they still fire if the loop stops.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A manual temp basal stops automatic dosing, but the loop icon stayed closed and then went stale and red while it ran, as if the loop were failing. Loop Failure notifications also fired.
Automation now counts as active only when Closed Loop is on and no manual temp basal is running (
DeviceDataManager.isAutomaticDosingActive). This is used for:While a manual temp basal runs, the Loop Failure notifications are rescheduled from each loop cycle rather than from the last loop that dosed. They don't fire during the manual temp, but they still do if the loop stops running.
Tested in the simulator with the mock pump:
Reported by Butch Weaver in Zulip #development ("New UI").