Skip to content

Fill the status bar column and cap the HUD row width on iPhone Duo #2628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ps2 merged 1 commit into from
Oct 29, 2026
Merged

Fill the status bar column and cap the HUD row width on iPhone Duo #2628

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions Loop/Views/HUDViewTableViewCell.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,8 @@ class HUDViewTableViewCell: UITableViewCell {

@IBOutlet var hudView: StatusBarHUDView!

override func awakeFromNib() {
super.awakeFromNib()
backgroundColor = .secondarySystemBackground
}
}
2 changes: 1 addition & 1 deletion Loop/Views/StatusTableView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ struct StatusTableView: View {
var body: some View {
ActionTabView {
wrappedView
.ignoresSafeArea(edges: .bottom)
.ignoresSafeArea(edges: [.horizontal, .bottom])
.onChange(of: viewModel.temporaryPresetsManager.activeOverride) { _, _ in
Task {
await viewController.reloadData(animated: true)
Expand Down
8 changes: 6 additions & 2 deletions LoopUI/Views/StatusBarHUDView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,11 +51,15 @@ public class StatusBarHUDView: UIView, NibLoadable {
containerView.translatesAutoresizingMaskIntoConstraints = false
self.addSubview(containerView)

// Use AutoLayout to have the stack view fill its entire container.
// Fill the container, up to a phone-like width on wide displays such as iPhone Duo's inner display.
let fillWidth = containerView.widthAnchor.constraint(equalTo: widthAnchor)
fillWidth.priority = .defaultHigh
NSLayoutConstraint.activate([
containerView.centerXAnchor.constraint(equalTo: centerXAnchor),
containerView.centerYAnchor.constraint(equalTo: centerYAnchor),
containerView.widthAnchor.constraint(equalTo: widthAnchor),
fillWidth,
containerView.widthAnchor.constraint(lessThanOrEqualTo: widthAnchor),
containerView.widthAnchor.constraint(lessThanOrEqualToConstant: 500),
containerView.heightAnchor.constraint(equalTo: heightAnchor),
])

Expand Down