Repository navigation
Status screen layout for iPhone Duo's inner display - #2606
Merged
Merged
Conversation
Landscape mode (charts only, no HUD, status row or action bar) was keyed to the screen being wider than tall. The unfolded inner display is wider than tall but has regular height, so after a fold/unfold the HUD and status row disappeared and the action bar was always hidden. Key it to compact vertical size class instead, in both the table view controller and ActionTabView. Chart row heights were sized from the longer screen dimension, which only makes sense in phone landscape; elsewhere use the table height so the charts fit the inner display. In inner landscape the status bar is vertical, so there is no top safe area and the first row met the display corners. The warning banner now runs to the top edge (the display corners round it) with its content inset by the corner-adapted safe area; without a banner, the table is inset by that amount. The status bar background view now tracks the table width, so it no longer stops at the launch width after unfolding.
This was referenced Oct 24, 2026
JoelonGit
pushed a commit
to JoelonGit/LoopWorkspace
that referenced
this pull request
Oct 24, 2026
Points LoopKit, G7SensorKit and Loop at their next-dev merges of LoopKit/LoopKit#626, LoopKit/G7SensorKit#80 and LoopKit/Loop#2605. Loop also picks up LoopKit/Loop#2606.
This was referenced Oct 29, 2026
ps2
added a commit
that referenced
this pull request
Oct 29, 2026
…2628) The next-dev counterpart of the fixes in #2627 that #2606 didn't have. - The status table now extends under the leading and trailing safe areas, as it did before it was hosted in SwiftUI, so the HUD row's grey fills the vertical status bar column beside the time instead of leaving a white box. Cell content still stays within the safe area. - The HUD cell's background matches the HUD view, so the cell is grey where it extends past the HUD. - The HUD row is capped at 500 pt and centered, so on the unfolded Duo it no longer stretches across the display with the CGM pill against the display corner. Every iPhone in portrait is narrower, so phones are unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the status screen on iPhone Duo's unfolded inner display (951×669 pt in landscape, regular size classes, vertical status bar on the trailing edge).
What was wrong
UIScreen.main.bounds.ActionTabViewhid the bar whenever the interface orientation wasn't portrait.Changes
edgeInsets(for: .safeArea(cornerAdaptation: .vertical)), iOS 26). Without a banner, the table gets that inset instead (16 pt on the Duo, 0 on other iPhones).Testing
Built with Xcode 27.1 and run in the simulator:
Not tested: the folded cover display.
Not in this PR
Apple's guidance for the Duo puts bar items in the vertical bar on the trailing edge, but only system bar items move there automatically. The action bar is a custom view, so it stays at the bottom, and it still hides on the cover display in landscape, as on any iPhone. Moving it to system toolbar items is a separate change.