Repository navigation
Refresh the managed HealthKit interval on CGM status updates - #2584
Merged
Merged
Conversation
The glucose store's managedDataInterval was only copied from the CGM manager at setup, so a change, such as G7 switching between direct and eavesdropping mode, took effect only after the next launch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
glucoseStore.managedDataIntervalwas copied from the CGM manager only insetupCGM. A change therefore took effect only after the next launch. G7 now changes it when switching between direct and eavesdropping mode (LoopKit/G7SensorKit#95).cgmManager(_:didUpdate:)now copies it again.Related: LoopKit/LoopKit#651
Tested: simulator build of the LoopWorkspace scheme.