Repository navigation
Count backfilled glucose in the daily analytics summary - #2575
Merged
ps2 merged 1 commit intoOct 14, 2026
Merged
Conversation
The daily summary replaces cgmFetchCount, which only counted readings fetched by polling and missed CGMs that push readings, with counts of CGM readings actually stored: glucoseCount, backfillCount, and maxBackfillAgeMinutes (the longest gap between a backfilled reading's time and when Loop received it).
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #2574. It needs LoopKit/LoopKit#646 for
StoredGlucoseSample.isBackfillandreceivedDate.The daily summary's
cgmFetchCountonly counted readings fetched by polling. CGMs that push readings, through thecgmManager(_:hasNew:)path, were never counted. It's replaced by counts of CGM readings actually stored, taken from whataddGlucoseSamplesreturns. Duplicates the store drops aren't counted.glucoseCount: CGM readings stored that day (user-entered readings excluded)backfillCount: how many of those were tagged backfill by the CGM pluginmaxBackfillAgeMinutes: the longest gap between a backfilled reading's time and when Loop received itThe per-fetch "CGM Fetch" hook is removed.
Plugin PRs that set the tag:
Uploaders:
Tested by building the LoopWorkspace scheme with all of the above.