Repository navigation
Don't run an action tab when a home swipe starts on the bar - #2565
Merged
Merged
Conversation
The tab bar sits over the home indicator and selects an item even when the touch turns into a home swipe, so closing Loop often left it on the bolus, presets, settings or carb screen. An action now runs only when a tap is also recognized, which a moving or cancelled touch fails. Taps still act on lift. VoiceOver and Switch Control activate items without a touch, so they act on selection as before.
shanselman
pushed a commit
to shanselman/LoopWorkspace
that referenced
this pull request
Oct 11, 2026
- Loop 0de85b71: don't run an action tab when a home swipe starts on the bar (LoopKit/Loop#2565) - LoopKit e4ebe3d3: extensible CGM event model, Modelv7 (LoopKit/LoopKit#635) - G7SensorKit 8fa9c73: nonzero-status glucose messages and serial-number device ids (LoopKit/G7SensorKit#85), sensor identity certificates (LoopKit#86), comment fixes (LoopKit#87), Simulator pairing over a Bluetooth bridge (LoopKit#89)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When you closed Loop with a home swipe that started on the bottom action bar, the bar often treated it as a tap. Coming back, Loop would be on the Bolus, Presets, Settings or Add Carbs screen.
Cause
ActionTabBaris aUITabBarsitting just above the home indicator, and its coordinator ran the tab's action straight fromtabBar(_:didSelect:). The tab bar reports a selection even when the touch turns into a home swipe.Fix
UITapGestureRecognizeron the bar (cancelsTouchesInView = false) runs alongside the bar's own touch handling.Testing
Tested on an iPhone 16 Pro: home swipes starting on the bar no longer open a screen, and taps on every tab work normally.