Skip to content

Add missing translations string, update WatchApp.xcscheme for Xcode 27 #2536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marionbarker merged 1 commit into from
Sep 27, 2026
Merged

Add missing translations string, update WatchApp.xcscheme for Xcode 27 #2536

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions Loop.xcodeproj/xcshareddata/xcschemes/WatchApp.xcscheme
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,6 @@
BuildableIdentifier = "primary"
BlueprintIdentifier = "43A943711B926B7B0051FA24"
BuildableName = "WatchApp.app"
BlueprintName = "WatchApp"
ReferencedContainer = "container:Loop.xcodeproj">
</BuildableReference>
</BuildableProductRunnable>
Expand All @@ -112,7 +111,6 @@
BuildableIdentifier = "primary"
BlueprintIdentifier = "43A943711B926B7B0051FA24"
BuildableName = "WatchApp.app"
BlueprintName = "WatchApp"
ReferencedContainer = "container:Loop.xcodeproj">
</BuildableReference>
</BuildableProductRunnable>
Expand Down
5 changes: 4 additions & 1 deletion Loop/Localizable.xcstrings
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19120,7 +19120,7 @@
}
},
"Favorite Foods" : {
"comment" : "Title for Favorite Foods view",
"comment" : "Label for Favorite Foods icon in Settings\nTitle for Favorite Foods view",
"localizations" : {
"de" : {
"stringUnit" : {
Expand Down Expand Up @@ -35079,6 +35079,9 @@
}
}
},
"Simplify Carb Entry" : {
"comment" : "Subheading for Favorite Foods in Settings"
},
"since %@" : {
"comment" : "Format fragment for a start time",
"localizations" : {
Expand Down
4 changes: 2 additions & 2 deletions Loop/Views/SettingsView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -365,8 +365,8 @@ extension SettingsView {
LargeButton(action: { sheet = .favoriteFoods },
includeArrow: true,
imageView: Image("Favorite Foods Icon").renderingMode(.template).foregroundColor(carbTintColor),
label: "Favorite Foods",
descriptiveText: "Simplify Carb Entry")
label: NSLocalizedString("Favorite Foods", comment: "Label for Favorite Foods icon in Settings"),
descriptiveText: NSLocalizedString("Simplify Carb Entry", comment: "Subheading for Favorite Foods in Settings"))
}
}

Expand Down