Repository navigation
Refactor RetrospectiveCorrection Initialization - #2014
Merged
Merged
Conversation
Contributor
|
I merged recent dev commits into this branch and proved it builds. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request solves the issue with toggling IRC On/Off without re-starting the app.
I did not want to re-create the RetrospectiveCorrection class for each evaluation or loop, therefore a new computed property retrospectiveCorrection is added in LoopDataManager. This property checks the integralRetrospectiveCorrectionEnabled flag in UserDefaults, and based on its state, it creates an instance of IntegralRetrospectiveCorrection or StandardRetrospectiveCorrection. This instance is then cached and reused unless the flag's value changes.
Two new private variables, lastIntegralRetrospectiveCorrectionEnabled and cachedRetrospectiveCorrection, have been added to support the caching mechanism.
By removing the instance creation logic from the "Static configuration" block in LoopSettings, it recognizes that this process is, in fact, not static. Moreover, the LoopSettings class adheres to the Equatable protocol, which makes it unsuitable for holding a cache of the RetrospectiveCorrection instance.