Repository navigation
Conversation
|
I was having the same issue. This fixes it for me. 👍 |
Collaborator
|
This is not the right fix. "Never cache the device token locally on the user's device." from https://developer.apple.com/documentation/uikit/uiapplicationdelegate/1622958-application . iOS reports the token to Loop at some point in the startup cycle. If Loop uploads settings before then, the token may be nil. The right fix is probably either prevent settings uploads until the token is reported, or find a way in NS to use the last non-nil token. Haven't really dug into this yet, but welcome anyone wanting to do so, considering the above. |
Contributor
|
Ok cool. Thanks for looking into. |
Contributor
Author
|
Further discussion on these comments in #1536 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was getting an error "Could not find deviceToken in loopSettings." error while trying to send push notifications. It appears the token gets set to LoopSettings.deviceToken but that value isn't stored to LoopSettings.
I'm not very familiar with this area of code or how it interacts with
StoredSettings, which also includes a device token. So this may not be the appropriate fix.