Repository navigation
Adjustments to pump status uploading: - #101
Merged
Merged
Conversation
loudnate
commented
Aug 5, 2016
loudnate
commented
Collaborator
- Removing some unnecessary state
- Preventing a pre-bolus status read from triggering the loop and history dump
* Removing some unnecessary state * Preventing a pre-bolus status read from triggering the loop and history dump
|
|
||
| // MARK: Pump data | ||
|
|
||
| private var latestPumpStatusDate: NSDate? |
Collaborator
Author
There was a problem hiding this comment.
This was exactly the same as (and in-sync with) the existing latestReservoirValue.startDate, so I just reverted the uses of this one.
erikdi
pushed a commit
to erikdi/Loop
that referenced
this pull request
Feb 10, 2019
ps2
pushed a commit
that referenced
this pull request
Aug 4, 2020
…101) * LOOP-1006: Make 60- and 120-minute "Loop not Looping" alert critical * PR Feedback * Also check feature flag and iOS > 12.0
jeremybarnum
pushed a commit
to jeremybarnum/Loop
that referenced
this pull request
Aug 13, 2026
…long Three blocks tightened, 31 lines out for 21 in. The glance-mirror note still says never read dataAccessQueue from main and why (the queue is held across a dose cycle whose radio poll runs to 15 s), without the millisecond-by-millisecond reconstruction of the build that proved it. The nil-sensorID note keeps the insight that matters — a forgotten identity can leave the watch unable to re-acquire at all, not merely slow — and drops the three timestamps. The LoopKit#101 acquisition gate was left substantially as it was, deliberately. Its constants are tuning rationale, not narrative: the 6.5 min freshness cutoff, the 3 s idle test, the 2.5 s minimum hold and the ad-at-:48.197-vs-INGEST-at-:48.050 timing that justifies it. Strip those and the next person to touch the gate has no way to know which numbers are load-bearing. Only its build/census reference went. That distinction is the whole rule: cut what happened, keep what a future change needs to not break. A comment that is long because the thing is genuinely subtle is not the target. Comments-only proof empty. 25 watch tests green. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.