Skip to content

Carb entries over maximum limit show an alert that cannot be dismissed #946

Closed

Description

@panctronic

Describe the bug
Entering a carb size >250g creates an onscreen alert that cannot be closed. The only resolution is to force close the app.

Attach an Issue Report
Tap the Loop settings icon on the bottom of the screen, then tap Issue Report and attach it to this ticket.

To Reproduce
Steps to reproduce the behavior:

  1. Click new carb entry
  2. Enter a value >250g (2,356g for example)
  3. Click save
  4. See error

Expected behavior
An error appears that can be dismissed, so the input can be corrected.

Screenshots
IMG_1483

Phone

  • Hardware: iPhone XS
  • OS Version: 12.2

Loop Version

  • Version Number: 1.10.0
  • Repo: LoopKit/Loop omnipod-testing branch

CGM

  • Device: Dexcom G6
  • Manager app: Dexcom App

Pump

  • Manufacturer: Omnipod
  • Model: Eros
  • Firmware version: n/a

Additional context
Add any other context about the problem here.

Activity

  1. vpdn commented on May 5, 2019

    @vpdn

    This bug seem to have popped up with a refactoring done in bf4166b. The UIViewController.swift helper has been replaced but the 'OK' not readded.

  2. Kdisimone commented on Oct 9, 2019

    @Kdisimone
    Collaborator

    fixed by PR mentioned above, tested and confirmed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions