You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
1.3.x: Trend arrow missing from current BG value (in header/dashboard) #456
Yes, I think I see what's going on. It was part of the CGM refactor that happened in this version. We track a variable called latestPumpStatusFromMySentry that contains trend from mysentry packets. We still track that var, but the displayed trend arrow comes from sensorState on the cgm data manager (EnliteCGMManager). I think we should get rid of latestPumpStatusFromMySentry, and instead update the instance of EnliteCGMManager with a new sensorState when a mysentry packet comes in, and also make sure to not overwrite sensorState when history cgm data is fetched, unless the history cgm value is newer.
I don't run Enlite, so this would be a hard change for me to test. Are you able to attempt this change and submit a PR?
Any kind of update on this? I would love the trend arrows to be back for elite users. (Still not working on latest dev build). Would like to help but don't know where to begin (very new to coding).
Activity
ps2 commentedon Apr 25, 2017
What CGM are you using?
danibjor commentedon Apr 25, 2017
Enlite. It did work before. Tried with the latest Dev bits from approx 24 hours back, and it's still missing
ps2 commentedon Apr 25, 2017
I don't believe we parse arrows on enlite on x22. Are you x23? Have you done a mysentry pairing?
danibjor commentedon Apr 26, 2017
My bad. Should know better than not including basic stuff when reporting issues..
754 EU pump
That's running pre-1.3 (with trend arrow)
ps2 commentedon Apr 26, 2017
Yes, I think I see what's going on. It was part of the CGM refactor that happened in this version. We track a variable called latestPumpStatusFromMySentry that contains trend from mysentry packets. We still track that var, but the displayed trend arrow comes from sensorState on the cgm data manager (EnliteCGMManager). I think we should get rid of latestPumpStatusFromMySentry, and instead update the instance of EnliteCGMManager with a new sensorState when a mysentry packet comes in, and also make sure to not overwrite sensorState when history cgm data is fetched, unless the history cgm value is newer.
I don't run Enlite, so this would be a hard change for me to test. Are you able to attempt this change and submit a PR?
danibjor commentedon Apr 27, 2017
I'll take a look and see if I could debug this - and maybe provide a fix.
Any tips are welcome as I don't have the full overview after the stuff was refactored.
iMaces commentedon Sep 11, 2017
Any kind of update on this? I would love the trend arrows to be back for elite users. (Still not working on latest dev build). Would like to help but don't know where to begin (very new to coding).
LOOP-3830 PumpManager sync updates (#456)
Merge release/v1.1.0 into dev (#463)