Skip to content

Unit display on new glucose graph on lock screen #433

Closed

Description

@beached

Testing dev 22c42ce and the new glucose graph on the lock screen is using mg/dl unit even though I have selected mmol/L

image

Activity

  1. ps2 commented on Apr 3, 2017

    @ps2
    Collaborator

    Have you restarted Loop? I remember in the past we've had issues detecting the changeover.

  2. beached commented on Apr 3, 2017

    @beached
    ContributorAuthor

    I stopped it and disabled BT before updating and yes I just did it again

  3. beached commented on Apr 3, 2017

    @beached
    ContributorAuthor

    The graph in the Loop app is correct

  4. ps2 commented on Apr 3, 2017

    @ps2
    Collaborator

    tagging @bharat

  5. bharat commented on Apr 3, 2017

    @bharat

    yup, that's wrong. initial reaction is that the problem lies here:
    https://github.com/LoopKit/Loop/blob/dev/Loop%20Status%20Extension/StatusViewController.swift#L53

    will look into it.

  6. bharat commented on Apr 3, 2017

    @bharat

    actually, that's probably not it - that should just set the value regardless of units. there's likely some other deeper place in the charts code where we apply units to get the absolute value back out again. either way, will dig into it.

    @beached - would it be possible for you to share the StatusExtensionContext data that you have in the "Share Issue Report" section of Loop settings when this problem is occurring? it'd be useful to see what data is being shared from Loop to the extension.

  7. Kdisimone commented on Dec 30, 2017

    @Kdisimone
    Collaborator

    Asked around and confirmed. This issue appears to be resolved. Units are displaying in mmol 1b8ede2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions