Skip to content

Status widget - tapping on widget does not open app except for tapping on mini icon #360

Closed

Description

@wkcwells

Related to/regression of PR #334.

Something fishy seems to be going on here since this was addressed by the above PR, but never worked for me. (And I can't figure out anything that I could have done to break it.) It works if you tap on the small Loop icon in the upper left of the widget, but that seems to be using some automatic functionality of widgets.

This code in Loop/Extensions/NSBundle.swift is always returning nil for me:

    private var mainAppBundleIdentifier: String? {
        return object(forInfoDictionaryKey: "MainAppBundleIdentifier") as? String
    }

Activity

  1. wkcwells commented on Jan 4, 2017

    @wkcwells
    ContributorAuthor

    I have a simple change that appears to fix this. Will PR shortly.

  2. wkcwells commented on Jan 5, 2017

    @wkcwells
    ContributorAuthor
  3. bharat commented on Jan 5, 2017

    @bharat

    That looks like the right fix to me. I know I committed that same change, but I suspect I committed it to the wrong branch (my deploy branch) and it didn't go into my PR. Good catch, @wkcwells!

  4. Kdisimone commented on Oct 18, 2018

    @Kdisimone
    Collaborator

    Closed, fix was merged.

  5. added a commit that references this issue on Mar 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions