Maximum bolus is ignored #33

Activity

1. CrushingT1D commented on Jun 15, 2016

   

   CrushingT1D

   on Jun 15, 2016

   More actions

   I tested this by setting my max to 0.1u in app and giving myself a 0.2u bolus and it gave the bolus as well.
2. loudnate

   added

   bug

   on Jun 16, 2016
3. loudnate commented on Jun 16, 2016

   

   loudnate

   on Jun 16, 2016

   Collaborator

   More actions

   Yep – maxBolus is never used... 😊 https://github.com/loudnate/Loop/blob/master/Loop/Managers/DoseMath.swift#L131
4. amazaheri commented on Aug 21, 2016

   

   amazaheri

   on Aug 21, 2016

   More actions

   Related to this would be great to validate carb entry, yesterday Sam by mistake keyed 5523 gr vs 55 and Loop suggested 553 units.
5. loudnate

   added 2 commits that reference this issue on Sep 28, 2016

   Fixing a crash when displaying the max bolus error

   ...

   This issue will close once commit e264670 is merged into the 'dev' branch.

   e264670

   Improving VoiceOver accessibility for the HUD and Bolus screens (#192)

   ...

   This issue will close once commit 2b8392b is merged into the 'dev' branch.

   2b8392b
6. loudnate

   closed this as completedin 2b8392bon Sep 29, 2016
7. erikdi

   added a commit that references this issue on Feb 10, 2019

   Merge pull request LoopKit#33 from loudnate/swift2.2

   ...

   735bcac
8. ps2

   added a commit that references this issue on Jan 18, 2020

   Fix copy-frameworks script; missing quotes around environment variable (

   ...

   5985ead
9. jeremybarnum

   added 2 commits that reference this issue on Jul 24, 2026

   Fake BG sweep (LoopKit#33/R29): exercise the high-temp range Jeremy's…

   ...

   490b171

   Tests: pin the dosing limits Jeremy's physiology cannot produce (Loop…

   ...

   85de766