Skip to content

Wrong carb entry causes Loop to hang #312

Closed
LoopKit/LoopKit
#104

Description

@kajanilssen

If a user enters carbs, and then decided to edit carb hours there is a possibility that Loop hangs.

Example: User enters 10 g of carbs with 180 minutes absorption time, and then decides to change this to 240 by edit manually the number is added to the existing number if the user doesn't delete the previous number. This will then be saved as "180240" absorption time. After save, Loop seems to work fine, but the long absorption time will cause Loop to hang - not communicating with Rileylink, no new BG number is captures, and the phone is slow. After 20 minutes the user will get a Loop has failed warning. Restarting the app makes the GUI strange - the graphs and Nightscout is strange due to that Loop has calculated numbers far into the future it seems.

Even if the user noticed that the number was wrongly saved, Loop seems to lock up if the user changes absorption time back to 240. Have to force close Loop and restart.

Solution: There should be a max number for carbs absorption time (for example 999).

img_0068
img_0066
img_0067
looperror1

Activity

  1. christerjensen commented on Dec 11, 2016

    @christerjensen

    Sorry - reported with wrong user (a user I helped solve Nightscout problem yesterday).

  2. walker0 commented on Dec 11, 2016

    @walker0
    Contributor

    I have seen this before and experienced the same symptoms. It doesn't seem to crash with only 3 characters in my testing so I think we should limit the text field to 3 characters. This provides 16.65 hours of possible carb absorption (should be more than long enough for everyone).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions