You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
DoseMath.recommendTempBasalFromPredictedGlucose has a deceptive default value for allowPredictiveTempBelowRange #293
The default is for this value to be false, which can (and has) confused the reader to believe that this value is not set by default. But in actuality, this function is only called from:
which forces the value to be true. This is a significant deviation from expectations unless you read the code carefully.
I propose that we make this value non-optional. It should be relatively easy - all we have to do is update the unit tests to force the value to be false anywhere that it's missing.
Jim (CrushingT1D) suggests doing research to see if/when this bit was flipped.
Jim also suggests dropping it from the docs, unless we want to mention that it's something that can be disabled.
Activity
bharat commentedon Dec 1, 2016
Jim (CrushingT1D) suggests doing research to see if/when this bit was flipped.
Jim also suggests dropping it from the docs, unless we want to mention that it's something that can be disabled.
bharat commentedon Dec 24, 2016
This was merged in #297
Fix TrueTime debug logging (#293)