Skip to content

DoseMath.recommendTempBasalFromPredictedGlucose has a deceptive default value for allowPredictiveTempBelowRange #293

Closed

Description

@bharat

The default is for this value to be false, which can (and has) confused the reader to believe that this value is not set by default. But in actuality, this function is only called from:

allowPredictiveTempBelowRange: true

which forces the value to be true. This is a significant deviation from expectations unless you read the code carefully.

I propose that we make this value non-optional. It should be relatively easy - all we have to do is update the unit tests to force the value to be false anywhere that it's missing.

Activity

  1. bharat commented on Dec 1, 2016

    @bharat
    Author

    Jim (CrushingT1D) suggests doing research to see if/when this bit was flipped.
    Jim also suggests dropping it from the docs, unless we want to mention that it's something that can be disabled.

  2. bharat commented on Dec 24, 2016

    @bharat
    Author

    This was merged in #297

  3. added a commit that references this issue on Nov 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions