Skip to content

Loop app has a dependency on WatchApp Extension/Model/GlucoseTrend  #280

Closed

Description

@bharat

Seems slightly off to me to have the main Loop app have a dep on the WatchApp Extension. Am I missing something? Should we move that model into Loop/Models?

Activity

  1. loudnate commented on Nov 27, 2016

    @loudnate
    Collaborator

    Because the code is shared between platforms, it has to be linked to both targets. You're issue here is merely one of directory placement, not actually dependency relationships, and I'm sure a PR would be accepted.

  2. bharat commented on Dec 1, 2016

    @bharat
    Author

    resolved.

  3. ps2 commented on Dec 1, 2016

    @ps2
    Collaborator

    Just FYI, github will automatically close tickets like this when their linked PRs are merged into master.

  4. bharat commented on Dec 1, 2016

    @bharat
    Author

    ah, thanks for the tip.

  5. added a commit that references this issue on Nov 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions