Skip to content

Feature Request: Add Setting for maxCarbEntry #1862

Closed

Description

@marionbarker

Is your feature request related to a problem? Please describe.
It is possible to make an error typing in a carb entry in grams. For individuals who use small amounts of carbs, it would be helpful for them to select a maxCarbEntry in Settings.

Describe the solution you'd like
Add an option to configure the maximum carb entry for a single event.
For example, the user could select 99 g to avoid an accidental entry of 115 instead of 15.

Describe alternatives you've considered

  1. A code customization is already provided in LoopDocs to modify the value.
  2. This could be added as switch in iOS Settings->Loop with the LoopPatches add-on, but it is far better to incorporate into Loop.

Activity

  1. marionbarker commented on Dec 17, 2022

    @marionbarker
    ContributorAuthor

    Two PR have been submitted which add a warning limit to the existing hard limit for carb quantity.

    • New warning limit is 99 g.
    • Hard (max) limit remains 250 g.

    Values for warning and max quantity are set in LoopConstants.

    Loop PR 1873

    LoopKit PR 438

    Obsoleted design details

    Design:

    • User enters any value up to 99 g, value is accepted
    • User enters value between 100 g and 250 g, user is shown a modal screen that warns value is above 99 g
      • User then choses to continue with that value or can edit quantity
      • See first image for the warning message
    • User enters value > 250 g, they cannot continue with that value
      • See second image for updated message

    IMG_0294

    IMG_0293

  2. marionbarker commented on Dec 18, 2022

    @marionbarker
    ContributorAuthor

    Updated graphics when LoopKit PR 468 was updated with new messages.

  3. github-actions commented on Jul 19, 2023

    @github-actions

    This issue is stale because it has been open for 30 days with no activity.

  4. marionbarker commented on Jul 30, 2023

    @marionbarker
    ContributorAuthor

    I'm closing this. We have added safety warnings with both large meals and when overrides are set.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions