Skip to content

Display of mmol/L units  #159

Closed
Closed
Display of mmol/L units #159
Milestone
1.0

Description

@beached
beached
opened on Sep 5, 2016

It looks like Loop is trying to display too many digits for mmol/L. Only 3 are ever needed at most. Actually , when the pump reports a bg <=99mg/dl only 2 are needed( so <=5.5mmol/L) but for consistency 3 is usually fine.

As one can see, this causes formatting bugs
bg display

Seeing as the data from the pump expresses the info in mg/dl and generally has 3 significant digits this could be accomplished with a formatting flag of %.1f

Activity

  1. beached commented on Sep 5, 2016

    @beached
    beached
    on Sep 5, 2016
    ContributorAuthor

    I am testing the use of

    numberFormatter.usesSignificantDigits = true
numberFormatter.minimumSignificantDigits = 2
numberFormatter.maximumSignificantDigits = 3

    To format the glucose hud display.

  2. loudnate commented on Sep 5, 2016

    @loudnate
    loudnate
    on Sep 5, 2016
    Collaborator

    Thanks – the NSNumberFormatter significant digits setting is exactly how I planned to fix these cases.

    The screenshots are really helpful. Please add any more where things aren't correct to this ticket!

  3. beached commented on Sep 5, 2016

    @beached
    beached
    on Sep 5, 2016
    ContributorAuthor

    I was thinking that maybe, excuse my swift, but a member of the HKUnit that formats blood glocose or a subtype of sorts that does it. then any string for a glucose uses that.

  4. loudnate commented on Sep 5, 2016

    @loudnate
    loudnate
    on Sep 5, 2016
    Collaborator

    Yeah, that's what's existed here: https://github.com/loudnate/LoopKit/blob/master/LoopKit/HKUnit.swift#L21-L28

  5. beached commented on Sep 6, 2016

    @beached
    beached
    on Sep 6, 2016
    ContributorAuthor

    So that fixed the issue in issue in the glucosehud. Not the graphs or other areas.
    fixed

  6. beached commented on Sep 16, 2016

    @beached
    beached
    on Sep 16, 2016
    ContributorAuthor

    Looks like the retrospective correction screen is hardwired to mg/dl
    image

  7. beached commented on Sep 16, 2016

    @beached
    beached
    on Sep 16, 2016
    ContributorAuthor

    Actually, I am wrong, it does eventually but the scale is off
    image

  8. beached
    closed this as completedon Sep 16, 2016

  9. beached commented on Sep 16, 2016

    @beached
    beached
    on Sep 16, 2016
    ContributorAuthor

    The units updated after checking/unchecking

  10. beached
    reopened this on Sep 16, 2016
  11. loudnate
    added this to the 1.0 milestone on Sep 17, 2016
  12. loudnate
    added 2 commits that reference this issue on Sep 29, 2016

    Graph improvements

    b07de8a

    Graph improvements (#193)

    339625b
  13. loudnate
    closed this as completedin #195on Sep 29, 2016
  14. loudnate
    added 2 commits that reference this issue on Sep 30, 2016

    Better fix for #159

    de413d1

    Better fix for #159 (#199)

    04f9c79
  15. ps2
    added a commit that references this issue on Aug 4, 2020

    LOOP-1492: support therapy settings max bolus (#159)

    491439a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions