Skip to content

Read the sensor card in phrases with VoiceOver #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ps2 merged 1 commit into from
Oct 12, 2026
Merged

Read the sensor card in phrases with VoiceOver #92

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions G7SensorKitUI/Views/G7SettingsView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -572,6 +572,7 @@ if viewModel.sessionMode == .eavesdropping {
Spacer()
remainingTime
}
.accessibilityElement(children: .combine)
G7LifecycleBar(
progress: viewModel.progressBarProgress,
color: sessionIsOver ? Color(.systemGray3) : color(for: viewModel.progressBarColorStyle)
Expand All @@ -587,6 +588,7 @@ if viewModel.sessionMode == .eavesdropping {
Spacer()
lastReadingAge
}
.accessibilityElement(children: .combine)
}
}
.padding(.vertical, 4)
Expand Down Expand Up @@ -643,6 +645,8 @@ if viewModel.sessionMode == .eavesdropping {
.foregroundColor(.secondary)
}
}
.accessibilityElement(children: .ignore)
.accessibilityLabel(sessionLengthFormatter.string(from: remaining) ?? "")
}
case .unpaired, .searching, .connecting, .gracePeriod, .expired, .failed:
EmptyView()
Expand Down Expand Up @@ -706,6 +710,7 @@ if viewModel.sessionMode == .eavesdropping {
HStack(spacing: 8) {
if let trend = viewModel.lastGlucoseTrend {
badge(text: trend.symbol, color: glucoseTintColor)
.accessibilityLabel(trend.localizedDescription)
} else {
badge(systemName: "minus", color: glucoseTintColor)
}
Expand Down Expand Up @@ -748,6 +753,8 @@ if viewModel.sessionMode == .eavesdropping {
: LocalizedString("hr", comment: "Unit after the hours-since-last-reading number"))
.foregroundColor(.secondary)
}
.accessibilityElement(children: .ignore)
.accessibilityLabel(sessionLengthFormatter.string(from: TimeInterval(minutes * 60)) ?? "")
}
}
}
Expand All @@ -759,6 +766,7 @@ if viewModel.sessionMode == .eavesdropping {
.foregroundColor(.white)
.frame(width: 28, height: 28)
.background(Circle().fill(color))
.accessibilityHidden(true)
}

/// A hollow variant, for states that are pending rather than alarming.
Expand All @@ -768,6 +776,7 @@ if viewModel.sessionMode == .eavesdropping {
.foregroundColor(color)
.frame(width: 28, height: 28)
.overlay(Circle().stroke(color, lineWidth: 2))
.accessibilityHidden(true)
}

private func badge(text: String, color: Color) -> some View {
Expand Down