Repository navigation
Conversation
Readings whose algorithm state has no reliable glucose produce a sensorIssue event through CgmSensorStateReporter.
This was referenced Oct 7, 2026
Contributor
|
Thanks @bjorkert. This is carried forward in #90 on the extensible CGM event model (LoopKit/LoopKit#635, LoopKit/LoopKit#637), with you as co-author. One change from this PR: the CGM manager does its own dedup in its persisted state, so there's no shared reporter on the storage side. |
ps2
added a commit
that referenced
this pull request
Oct 12, 2026
Each state is recorded once while it lasts, with the algorithm state's name as the code and isFatal for sensor failures. A reliable reading or a new sensor clears it, so a state that returns is recorded again. The last state is kept in the manager state, so a relaunch stays quiet. A failure is recorded before the sensorEnd that closes the session. Ports #84 to next-dev, keeping the bookkeeping in the manager instead of a shared LoopKit reporter. Co-authored-by: Jonas Björkert <jonas@bjorkert.se>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
G7 readings whose algorithm state has no reliable glucose now produce a sensorIssue event, which NightscoutService uploads as a note. Nothing changes in glucose handling or what the app shows.
Depends on LoopKit/LoopKit#634. Part of LoopKit/LoopKit#634, LoopKit/NightscoutService#34, LoopKit/CGMBLEKit#223 and #84. Together they replace the cgm_sensor_notes customization from loopandlearn/customization#84 and match nightscout/Trio#1420, so notes from Loop and Trio read the same.