Repository navigation
Conversation
The sensor reports its warm-up in the extended version message, which arrives a few seconds after pairing, so the success screen watches for it and says how long this sensor's warm-up is. Until it arrives the screen says readings start once the sensor has warmed up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continues #82 by @loudestnoise, who spotted that the Sensor Paired screen said "about 30 minutes" of warm-up even for 15-day sensors, which take longer. David's commit is kept as the first commit here.
The second commit takes the suggestion from #82: we know which sensor was just paired, so say what its warm-up actually is. The sensor reports its warm-up duration in the extended version message. That message arrives a few seconds after pairing, so the screen watches the manager's state and updates when the duration comes in:
The string catalog swaps the old key for the two new ones (neither had translations).
Testing: the LoopWorkspace scheme builds. Not yet tried against a real pairing.