Repository navigation
Conversation
We dropped them in 22f3db6 This adds them back by handling the body stream differently and also retries the calls that go to troytown rather than only retrying the GCS calls
jibsheet
commented
Nov 5, 2026
| @@ -1,4 +1,4 @@ | |||
| version: 2 | |||
| version: 2.1 | |||
Author
There was a problem hiding this comment.
Circle retired 2 and tests don't run without this. There are some other cleanups we can do but I did the easy change
jibsheet
commented
Nov 5, 2026
| 'gcs-token': 'gcs-bucket', | ||
| 'gcs-bucket': 'gcs-token', | ||
| }) | ||
| .option('max-retries', { |
Author
There was a problem hiding this comment.
I fussed around and yargs handles the old layout of these and the new global version fine
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While fixing some 502 errors in the SaaS cluster, bring back retries in the client (we dropped it in 22f3db6)