Repository navigation
fix(studio): close() ends open connections so a restart with a browser tab open exits - #1192
Merged
Merged
Conversation
…r tab open exits instead of hanging server.close() waits for every open connection, and a Studio tab holds a WebSocket open forever, so SIGTERM hung until Docker killed the container (exit 137 after the stop timeout) and agents never reported 'stopped'. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After deploying alpha.127 (with #1191),
docker stopon the live Studio took the full timeout and exited 137: Docker had to kill it.Cause: Studio's
close()ends withserver.close(), which waits for every open connection. Every Studio tab holds a WebSocket (/agents/:id/stream) open forever, so with a browser open shutdown never finished. Reproduced locally: no socket → exit 0 in 6 ms; one open WebSocket → still running after 8 s.Fix: track the server's sockets and destroy them after
server.close()starts. All the graceful steps (passes, workspaces, MCP servers, observe reporters, collector) still run first.Test:
server/__tests__/shutdown.test.tsopens a WebSocket and assertsclose()finishes. Fails before, passes after. Studio server suite: 138/138.🤖 Generated with Claude Code