Skip to content

Deleted Themes are still there #973

Description

@prevail90

LinkStack version

v4.8.6

Description

I added a custom theme but when I tried to update it or delete it, the theme version would update but the theme itself wouldn't when I tried to update it. When I tried to delete it, it's deleted but not really as I tried to completely redo the custom theme with a new version starting at 1.0 and it gives me the error instead of manual update.

Details about your system

Docker

How to reproduce

add custom theme and delete try to re-add theme but with a lower version number.

Possible Solution

No response

Additional Context

No response

Activity

  1. sridharkalaibala commented on Sep 13, 2026

    @sridharkalaibala

    I checked the deletion path on current main (7bd6cea). In AdminController::deleteTheme, File::deleteDirectory() is called but its result is ignored; the request redirects to the theme page regardless. The theme selector also reads directories directly from themes/.

    That means returning to the page does not by itself establish that the directory was removed. A filesystem deletion failure is one possibility, but I have not reproduced your Docker setup or established the cause of the version error.

    Could you check whether themes/<your-theme-folder> and its readme.md still exist inside the running container immediately after deletion, before re-importing? Please also share the exact re-import error and whether that theme directory is a bind mount. If it remains, the PHP process user's write permissions on the theme directory and its parent would help narrow this down. No credentials or full environment file needed.

    A useful code improvement would be to surface an unsuccessful deletion instead of silently redirecting; the folder/error evidence would help confirm whether that addresses this report or whether the import/update path also needs a fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions