Skip to content

[0.4.x] libvisual + libvisual-plugins: Require a C++11 compiler - #276

Merged
hartwork merged 5 commits into
0.4.xfrom
0.4.x-cxx11-compiler
Feb 14, 2023
Merged

[0.4.x] libvisual + libvisual-plugins: Require a C++11 compiler#276
hartwork merged 5 commits into
0.4.xfrom
0.4.x-cxx11-compiler

Conversation

@hartwork

@hartwork hartwork commented Feb 13, 2023

Copy link
Copy Markdown
Member

No description provided.

@hartwork
Plugins (gforce): Resolve multi-character character constants
17a590e 
The related warning is -Wmultichar, can be fatal.
Idea from https://stackoverflow.com/a/55505870/11626624
@hartwork
libvisual: Run autoreconf twice if necessary
7a89960 
Symtom was (on macOS):
> [..]
> aclocal: error: too many loops
> aclocal: Please contact <bug-automake@gnu.org>.
>  at /usr/local/Cellar/automake/1.16.5/share/automake-1.16/Automake/Channels.pm line 655.
> 	Automake::Channels::msg("automake", "", "too many loops") called at /usr/local/Cellar/automake/1.16.5/share/automake-1.16/Automake/ChannelDefs.pm line 226
> 	Automake::ChannelDefs::prog_error("too many loops") called at /usr/local/bin/aclocal line 1187
> autoreconf: error: aclocal failed with exit status: 255
@hartwork
Plugins: Run autoreconf twice if necessary
a465f68 
Symtom was (on macOS):
> [..]
> aclocal: error: too many loops
> aclocal: Please contact <bug-automake@gnu.org>.
>  at /usr/local/Cellar/automake/1.16.5/share/automake-1.16/Automake/Channels.pm line 655.
>       Automake::Channels::msg("automake", "", "too many loops") called at /usr/local/Cellar/automake/1.16.5/share/automake-1.16/Automake/ChannelDefs.pm line 226
>       Automake::ChannelDefs::prog_error("too many loops") called at /usr/local/bin/aclocal line 1187
> autoreconf: error: aclocal failed with exit status: 255
@hartwork
libvisual: Require a C++11 compiler + enable C++11 features
fe248f8 
Related documentation:
https://www.gnu.org/software/autoconf-archive/ax_cxx_compile_stdcxx.html
@hartwork
Plugins: Require a C++11 compiler + enable C++11 features
8ca2622 
Related documentation:
https://www.gnu.org/software/autoconf-archive/ax_cxx_compile_stdcxx.html
@hartwork hartwork added this to the 0.4.2 milestone Feb 13, 2023
@hartwork
hartwork requested a review from kaixiong February 13, 2023 18:25
@hartwork
hartwork marked this pull request as ready for review February 13, 2023 18:25
This was referenced Feb 13, 2023
Merged
Closed
@kaixiong

kaixiong commented Feb 14, 2023

Copy link
Copy Markdown
Member

@hartwork master avoids reinterpret_cast by specifying the 4-character value in hexadecimals or using a macro to build up the 4-byte integer value instead. It'd be good to follow it. On the other hand, the changes are quite large and were also made to make it work on Windows (I think?). I'll leave it up to you to decide.

References: f59364b, e012c97

@hartwork

hartwork commented Feb 14, 2023

Copy link
Copy Markdown
Member Author

@kaixiong maybe the VAL(a,b,c,d) approach over there is best, e.g. because it self-answers all potential questions about endianness. Let's first get the compilation fixed and then use VAL(a,b,c,d) eventually, clean up more and being more cross-branch-consistent. Thank you! 👍

@hartwork
hartwork merged commit b0a35cc into 0.4.x Feb 14, 2023
@hartwork
hartwork deleted the 0.4.x-cxx11-compiler branch February 14, 2023 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kaixiong kaixiong kaixiong approved these changes

Assignees

No one assigned

Labels

enhancement porting: TODO

Projects

None yet

Milestone

0.4.2

Development

Successfully merging this pull request may close these issues.

2 participants

@hartwork @kaixiong