Repository navigation
Conversation
We can only copy 256 entries if we have them... (based on 0.4.x commit d1edda9)
kaixiong
reviewed
Jan 24, 2023
kaixiong
left a comment
kaixiong
left a comment
Member
There was a problem hiding this comment.
@hartwork, I don't think this patch is correct. It's clearly intended to copy palettes with smaller than 256 entries and fill the remaining with black.
What's slightly questionable in this implementation is the use of visual_mem_set() to zero out the entries but it should be safe since SDL_Color is just a regular C struct defined with uint8_t (unless I'm missing something about std::array's guarantees regarding memory layout).
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We can only copy 256 entries if we have them...
(based on 0.4.x commit d1edda9 from pull request #213)