Repository navigation
[0.4.x] libvisual: Backport lv-tool from master to 0.4.x - #150
Conversation
5243c79 to
da6e83d
Compare
|
@kaixiong I have taught lv-tool to only upgrade the actor to |
There was a problem hiding this comment.
@hartwork Code looks good but there seems to be some tab indentation mixed into lv_tool.cpp. I can't quite tell with Github's code viewer. The convention is four space characters for each indent level. Would be good to fix that.
We probably should try and get a usable editorconfig to make this easier to deal with. I run into the same problem now and then.
@kaixiong you're right, it's all spaces on # grep $'^\t' ./libvisual/tools/lv-tool/lv-tool.cpp | wc -l
0
# grep '^ ' ./libvisual/tools/lv-tool/lv-tool.cpp | wc -l
511…but some tab lines in here. I'll fix that 👍
It would be over-simplified to say that we have no tabs on # git grep -l $'^\t' | wc -l
290
# git grep -l $'^ ' | wc -l
681For # git grep -l $'^\t' | wc -l
373
# git grep -l $'^ ' | wc -l
361I believe we need both an editorconfig and CI enforcing clang-format, e.g. similar to what this |
Source commit for lv-tool.cpp is 841e335.
da6e83d to
d0b92e1
Compare
|
@kaixiong |
In particalr the code in methods .. - Display::create - Display::drain_events - Display::update_all .. is based on file libvisual/tools/lv-tool/display/sdl_driver.cpp off master at commit afa4b59.
Pointed out by AddressSanitizer
d0b92e1 to
6dddefb
Compare
6dddefb to
2c75fe0
Compare
|
@hartwork You're right. That's mostly in the C source files and headers and have remained so due to the concern you just raised. The worst violator in the C++ sections is lv_bin.cpp, lv_bin.h. The rest are kind of manageable. |
No description provided.