You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Erratic resizing of lv-tool window under GNOME Shell #161
When I try to resize the lv-tool visualization window on my GNOME Wayland desktop, the window jumps around erratically and resizes itself like it's suffering from a seizure.
@kaixiong is this with original SDL 1.2.x or with sdl12-compat? If I can trust my eyes, I get it (with X11!) on master with sdl12-compat (1.2.60) but not with plain SDL 1 (1.2.15_p20221201). You?
@kaixiong update: Even my SDL 1 toy at https://github.com/hartwork/sdl_video_demo shows this behavior with sdl12-compat 1.2.60. Are you okay with me taking this to sdl12-compat upstream for feedback? We could try sdl12-compat Git master before that, though. What do you think?
@kaixiong interesting. Does my demo show the same behavior for you? If it does, we can e.g. rule out any problems from the way lv-tool is draining all events in one go.
@kaixiong PS: I should note that (unlike SDL 2) SDL 1 does not yet have explicit support for Wayland. Maybe use of Wayland is an important part of this.
@hartwork so I tested lv-tool and your demo under GNOME/Wayland, GNOME/X.Org and Sway.
The issue only appears with SDL 1.2. Using GNOME/X.Org did not make much difference.
Under Sway, which is Wayland based, I did notice that the SDL 1.2 window auto-centers itself at the end of each resize drag. It is somewhat well behaved.
The same is probably happening on GNOME but much less consistently or gracefully.
changed the title [-]Erratic resizing of lv-tool window under GNOME Shell Wayland[/-][+]Erratic resizing of lv-tool window under GNOME Shell[/+]on Jan 15, 2023
@hartwork Thanks, I have replied there. But just to keep the main discussion here, I'll repeat the basic points:
It works, although content resizes still happen frequently. Slow content resize causes rather heavy flickering.
Debouncing based on time may be better. When a resize event is received, a short time window follows where subsequent resize events are 'absorbed'. Once the window expires, the content resize happens based on the latest dimensions. A subsequent resize event restarts the process.
Activity
hartwork commentedon Jan 12, 2023
@kaixiong is this with original SDL 1.2.x or with sdl12-compat? If I can trust my eyes, I get it (with X11!) on
masterwith sdl12-compat (1.2.60) but not with plain SDL 1 (1.2.15_p20221201). You?hartwork commentedon Jan 12, 2023
@kaixiong update: Even my SDL 1 toy at https://github.com/hartwork/sdl_video_demo shows this behavior with sdl12-compat 1.2.60. Are you okay with me taking this to sdl12-compat upstream for feedback? We could try sdl12-compat Git
masterbefore that, though. What do you think?kaixiong commentedon Jan 12, 2023
@hartwork I am on SDL 1.2.15, which comes with Pop_OS! 22.04.
Here's all the SDL packages on my system.
hartwork commentedon Jan 12, 2023
@kaixiong interesting. Does my demo show the same behavior for you? If it does, we can e.g. rule out any problems from the way lv-tool is draining all events in one go.
hartwork commentedon Jan 12, 2023
@kaixiong PS: I should note that (unlike SDL 2) SDL 1 does not yet have explicit support for Wayland. Maybe use of Wayland is an important part of this.
kaixiong commentedon Jan 12, 2023
@hartwork so I tested lv-tool and your demo under GNOME/Wayland, GNOME/X.Org and Sway.
The issue only appears with SDL 1.2. Using GNOME/X.Org did not make much difference.
Under Sway, which is Wayland based, I did notice that the SDL 1.2 window auto-centers itself at the end of each resize drag. It is somewhat well behaved.
The same is probably happening on GNOME but much less consistently or gracefully.
[-]Erratic resizing of lv-tool window under GNOME Shell Wayland[/-][+]Erratic resizing of lv-tool window under GNOME Shell[/+]hartwork commentedon Feb 3, 2023
@kaixiong I believe I have a fix at hartwork/sdl_video_demo#8 . What do you think?
kaixiong commentedon Feb 3, 2023
@hartwork Thanks, I have replied there. But just to keep the main discussion here, I'll repeat the basic points:
hartwork commentedon Feb 3, 2023
For the record @kaixiong and I agreed on debouncing at hartwork/sdl_video_demo#8 (comment) now.
hartwork commentedon Feb 7, 2023
Should be fixed on both
masterand0.4.x, closing as fixed. Please re-open as needed.Merge pull request #257 from Libvisual/lv-tool-debounce-resize-requests