Skip to content

chore: prune monorepo residue left after the CLI split (lint/gitleaks/pre-commit config, NOTICE, docs) #2097

Description

@cristim

Problem

After the split (main replaced by the CLI-only carve, de556ad), some config and doc files still reference monorepo-only paths. None of this affects the build or tests.

Items (from the independent re-review of the carve PR)

  1. .golangci.yml:105,111-114,130-134: exclusions for internal/testutil/, internal/api/ and internal/config/...|pkg/ladder/..., none of which exist. Prune them.
  2. .gitleaksignore:3 is a path, not a fingerprint, so gitleaks warns "Invalid entry". Remove it or replace it with a real fingerprint.
  3. .gitignore:95-102: frontend/* entries.
  4. .gitallowed:39-46: comments cite store_postgres_pgxmock_test.go and handler_*_test.go.
  5. .pre-commit-config.yaml: the comment at 51-55 cites internal/credentials/resolver.go; an exclude has frontend/src/index\.html; the gosec comment at 162-163 lists pkg/, providers/* modules.
  6. Makefile:89 vs scripts/gosec-hook.sh:38: the gosec exclude lists differ (the hook adds G117,G118,G122,G702-G706). Align them.
  7. NOTICE:15,43,47,51,59: aws-lambda-go, pgx, pgxmock, golang-migrate and testcontainers aren't in go.mod.
  8. docs/cli/cloud-setup.md:3,9 says "CUDly server reads them" and links to ../../README.md#deployment-self-hosted-via-terraform (the anchor is gone); docs/cli/README.md:15 says "self-hosted". Point these at LeanerCloud/cloud-commitments-platform.
  9. The cmd/configure_azure.go:113 and cmd/configure_gcp.go:82 help text says "CUDly CloudFormation stack name". Check that the wording is right for the CLI. The cmd/multi_service_stats.go:173 comment references "the MCP server's".
  10. ci.yml:61 has || true on gocyclo, which swallows a crash. ci.yml:463: Snyk is continue-on-error, so it's never gating.
  11. CLAUDE.md:53 says the module is "rooted at cmd/". It's rooted at the repo root; cmd/ is the main package.
  12. CONTRIBUTING.md:15: ./cudly --help prints no version. Add a --version flag or drop the line.

Acceptance

No monorepo-only paths remain in config or docs. CI stays green and every gate that ran before still runs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions