Conversation
Modernizes the Windows native-extension loader from legacy LoadLibraryW to LoadLibraryExW with LOAD_WITH_ALTERED_SEARCH_PATH. The .so's own directory is searched first for its transitive DLL imports — gems that bundle DLLs alongside the .so are found without walking PATH. Wall-clock impact in this setup is noise (deps for gtk3 live in ucrt64/bin via PATH, not next to the .so). Kept anyway as the recommended form on Win10+.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modernizes the Windows native-extension loader from legacy
LoadLibraryWtoLoadLibraryExWwithLOAD_WITH_ALTERED_SEARCH_PATH, so the.so's own directory is searched first for its transitive DLL imports. Gems that ship DLLs next to the.soare then found without walkingPATH.Wall-clock impact in this setup is noise — the gtk3 dependencies live in
ucrt64/binviaPATH, not beside the.so. Proposed anyway as the recommended form on Win10+.Windows-only. Not built or tested on Windows CI — measured in a local MSYS2/UCRT64 VM.