Skip to content

Solving Issues 53, 55 and 56 - #57

Merged
becega merged 3 commits into
masterfrom
Dev-Issues53-55-56
Apr 10, 2019
Merged

becega merged 3 commits into
masterfrom
Dev-Issues53-55-56

Conversation

@agomez08

Copy link
Copy Markdown
Contributor

-Made sure channels are added on top of the same task (Fixes #55).
-Change relative offset to -1 for DAQmx reads to return latest sample instead of waiting for the next one (Fixes #53)
-Retry creating tasks in case they already existed (Fixes #56 )

agomez08 added 3 commits April 9, 2019 18:43
… the last acquired sample instead of waiting for the next one.

Move this to Configure AI task.vi so it is set only once in initialization.
Fixes #53
…. After clearing tasks they are re-created.

Fixes #56
@agomez08
agomez08 requested review from becega and jacobson3 April 10, 2019 15:24
@DCAF-Builder

Copy link
Copy Markdown

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

DAQmx Module Runtime.lvclass--Configure AI Task.vi.png: capture

DAQmx Module Runtime.lvclass--Create DAQmx Tasks.vi.png: capture

DAQmx Module Runtime.lvclass--init.vi.png: capture

DAQmx Module Runtime.lvclass--input.vi.png: capture

@becega becega left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good

@becega
becega merged commit 3625e8b into master Apr 10, 2019
@becega
becega deleted the Dev-Issues53-55-56 branch April 10, 2019 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants