Repository navigation
fix: 34 defects found by a blueprint audit (bpfix 2026-11-09) - #1
Open
L0garithmic wants to merge 3 commits into
Open
L0garithmic wants to merge 3 commits into
L0garithmic wants to merge 3 commits into
Conversation
Gate held: build passed before and after (bump_deps.py, non-regressive). - @clack/prompts -> ^1.8.1 - @types/better-sqlite3 -> ^7.6.13 - @types/node -> ^20.19.43 - @types/picomatch -> ^4.0.3 - @xyflow/svelte -> ^1.7.1 - commander -> ^14.0.3 - fast-wrap-ansi -> ^0.2.2 - ignore -> ^7.0.14 - picomatch -> ^4.0.7 - svelte -> ^5.57.3 - svelte-check -> ^4.7.8 - tree-sitter-wasms -> ^0.1.13 - typescript -> ^5.9.3 - vite -> ^7.3.7 - web-tree-sitter -> ^0.27.1 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ed in the code (bpfix 2026-11-09)
- name matching: a qualified-name suffix shared by two cross-file symbols resolves to nothing (no guess); a method-call match needs two shared receiver words, the same-language bonus only ranks; one JS family set
- CLI: --filter matches whole directory names; numeric options take whole numbers only (1.5, 8garbage and abc are refused) through one option parser
- flow API: one live hop says a flow needs two symbols; every heuristic hop is labelled as a bridge
- frameworks: a Spring :prefix key binds only on a dot boundary and each controller keeps its own class prefix; Next.js routes per app root and export { handler as GET }; Laravel Controller@method accepts digits and underscores; Fabric keeps function-valued NativeProps
- LRU capacity is validated after flooring; DFS keeps parallel edges; explore keeps an evicted project's call counts; a blank watchdog value takes the default
- extraction: listDirectories refuses ../; a re-index re-attaches callers by qualified name; ancestor overrides are filtered to overridable kinds
- MCP: busy guidance makes no queue or health claim and the busy timeout is clamped to the timer limit; one initialize-instructions owner for session and proxy; a locally stopped transport runs its close handlers once; a just-created empty writer lock is not reclaimed
- one owner each for JS built-in member roots, the existence-name rewrites, DISPATCH_MIN_IMPLEMENTERS and the 0.6 dynamic-boundary constant; UI: consonant+y pluralizes to -ies, a stale keyboard index wraps, WireEntryRoute is WireRoute
- installer: permission-denied wording and the sudo offer only for EACCES/EPERM on POSIX
Each behaviour fix has a regression test. Box (hydra-aws): every test file run one at a time; the 11 files that fail here (resolution, extraction, dart-extension-type, fabric-view, frameworks-integration, rn-event-channel, value-reference-edges, installer-targets, cli-sync, install-sh-prune, bundle-launcher) fail with the same counts on the unchanged base 6dee0a2, and the new tests pass.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ged, 120 new files (116 regression test files, 4 shared helpers)
Each finding was confirmed in the code by a second reviewer and again by the fixer; findings that were not real or needed a product call were left as they were. Areas: framework resolvers (20 files: SvelteKit optional-only routes now also serve '/', Expo Router and Express share one balanced-delimiter scanner in src/resolution/delimiter-match.ts, ASP.NET, Django, Axum, Actix, Astro, Drupal, Erlang and more), language extractors (13), resolution (9), installer targets (8), the agent-eval scripts (14: one probe-lib.mjs for the probes' pure helpers, one readme-bench.json for the README A/B's repo list), graph, search, MCP, CLI, the UI's rune modules, the UI server and the telemetry dashboard. `*.svelte.test.ts` files run in the ui project, the one with the Svelte plugin.
One regression the full check found was fixed before this commit: a templated href segment (`/profile/@${...}`) may fill a mixed param segment (`@:user`) again, but still never stands in for a literal segment (expo-router scoreMatch).
Proof (hydra-aws, hnode job 20261110-021835-826f): tsc --noEmit exit 0; full vitest 4432 passed, 62 failed. Every failing file was rerun alone and then on HEAD: 11 fail on HEAD too (bundle-launcher, cli-sync, dart-extension-type, extraction, fabric-view, frameworks-integration, install-sh-prune, installer-targets, resolution, rn-event-channel, value-reference-edges), 28 pass alone (load flakes), none regressed. The two new agent-eval tests failed there only because the box copy of parse-run.mjs had CRLF line endings from a Windows checkout (a `#!` line ending in \r breaks the test runner's module wrap); with LF they pass (2 of 2), and git stores LF.
Also in this commit, two fixes the box found under the fixes: web-tree-sitter goes back to ^0.25.3 (0.25.10, the lockfile entry from before 6dee0a2). 0.27.1 cannot load the vendored Dart, Objective-C and Solidity grammars, so on a clean install 42 tests that pass on 0.25 fail; `ph testdiff --base-install` (hydra-aws job 20261110-032048-9744) reads FIXED 42, REGRESSED 0. And the Flask stacked-routes test now expects GET and POST for its methods=["GET", "POST"] routes: a methods list declares every verb as a route (python.ts), which its GET-only list predated.
Compared test by test against HEAD (`ph testdiff`, hydra-aws job 20261110-031320-aaec): 1,217 tests per side, none failing only here. .gitattributes now checks out every *.sh with LF, a Windows checkout included: a CRLF install.sh handed to /bin/sh exited 2 where installer-targets expects 1 (3 tests, on HEAD too). Gate run on Node 22 (package.json engines <25): on Node 26 the cli-sync tests read the unsupported-version banner as the command's output.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
34 defects a blueprint audit of this repo found, each confirmed in the code by a second reviewer and fixed with a regression test where behaviour changed (name matching, CLI option parsing, the flow API, the Spring, Next.js, Laravel and Fabric framework resolvers, the LRU cache, DFS, explore session state, extraction, type hierarchy, the MCP query pool, session, transport and writer lock, and the UI search model). The commit message lists every change.
Proof (hydra-aws): every test file run one at a time. The 11 files that fail on this branch (resolution, extraction, dart-extension-type, fabric-view, frameworks-integration, rn-event-channel, value-reference-edges, installer-targets, cli-sync, install-sh-prune, bundle-launcher) fail with the same counts on the unchanged base 6dee0a2; the new tests pass. Not merged into the base branch: it is the base of a separate change.
🤖 Generated with Claude Code