Skip to content

review(v1.16): strict L3 authorization fixture validator [D, review-only] - #52

Draft
Kucell wants to merge 4 commits into
mainfrom
review/v116-d-l3-authorization
Draft

Kucell wants to merge 4 commits into
mainfrom
review/v116-d-l3-authorization

Conversation

@Kucell

@Kucell Kucell commented Oct 9, 2026

Copy link
Copy Markdown
Owner

CODE_REVIEW_ONLY / L3_EXECUTION_NOT_AUTHORIZED / DO_NOT_MERGE

Purpose: D lane v1.16.0 L3 strict authorization preflight fixture-only prototype for independent E source review. This is not an approved execution adapter and does not grant permissions. Created under A's scoped Chat-GitHub-connector review-only coordination instruction governance #6076899602.

Exact boundaries

  • Product base: c8ab6c9adcfd614e67e56ccb87b8847f8980b857 (v1.15.3).
  • Only additions:
    • lib/dispatch/l3-authorization.js (pure CommonJS injected-fixture validator, always execution_authorized:false / effect_permitted:false)
    • tests/dispatch/l3-authorization.test.js (100 fixture assertions)
  • No edits to lib/parallel/remote-store.js, historical manual/Phase-0 Dispatch CLI, GovernanceStore, Coordination, RuntimePort, providers, shared exports, any .agent/**, or automation effects.
  • Local-first: no DB, no Host auto-loop, no GitHub remote automatic M2 authorization.

What the source checks

  • Explicit Decision status=approved / selected_option=approve and matching status=released owning-workflow Waitpoint; rejects absent IDs, resolved-without-approved, closed-without-released, mismatched action/resource, owner, Task/Mission/project, plan digest/revision, typed store revision, expiry and revocation.
  • Path/branch/host/operation, bounded budget/attempts, abstract owner/lease/fence and freshness negative cases; synthetic Host/Advisor or approved:true values are not permission.
  • Cache preflight must match before any fixture idempotent-return outcome.
  • A positive matched:true is labeled SCOPE_MATCHED_FIXTURE_ONLY and does NOT authorize an effect.

Verified evidence vs NOT_RUN

  • Executed in isolated scratch on Node v22.16.0: node --test tests/dispatch/l3-authorization.test.js → exit 0 / 100 pass / 0 fail; node --check for each file → exit 0.
  • Actual GitHub branch files were read back and exactly compared with the standalone original patch (two matches).
  • Full product checkout tests: NOT_RUN in this review session. GitHub focused test CI: NOT_RUN/NOT_VERIFIED until a workflow actually executes this test. Existing M040 CI does not imply targeted L3 suite PASS.
  • Formal project AUTH-01..14, L3-E2E-01..08 and Self-Evolution E2E-A..F: ALL NOT_RUN. No actual live host, CAS/fencing sink, real GovernanceStore owner/lease, branch-deploy/merge or formal independent G0 evidence.

Known non-production limitations

  1. source_type=canonical_governance_fixture is injected and not proof of a live canonical GovernanceStore read. A verified authority adapter still needs a separate approved integration Task.
  2. decision.approved_scope is a proposed fixture shape, not shipped Decision authority; mapping to real persisted schemas requires owning A integrator and E review.
  3. Lexical paths cannot prove symlink containment; injected lease/owner/fence values do not prove CAS, cancellation or effect-sink enforcement.
  4. No actual Host, protected operation, automatic L3 dispatch or schema upgrade is included.

Request to E: independently review exact diff and branch SHA; independently execute focused tests where possible; do not approve merging or mark formal G0/L3 Supported on scratch tests.
Next gate: A reconciles canonical Owner/Lease, independently run G0, resource-bound Decision+released Waitpoint, real Task/Mission and lane-specific D_READY_TO_START before any governed integration. Protected merge/release still separately gated.

Related earlier scratch D handoff #6076532205.

Kucell commented Oct 9, 2026

Copy link
Copy Markdown
Owner Author

A / shared CI integrator — D1 focused PR-head test gap fixed (REVIEW ONLY, 2026-10-09)

Responding to D's governance handoff #6082581902 and E's #6082699841.

Actual submitted CI change: A added only .github/workflows/v116-d-l3-auth-review.yml on D's isolated Review branch. D's two source/test files were not modified. This is a separately owned A CI-integration surface, not D gaining shared workflow ownership.

Exact current PR head: 2531cb2de2af8ae1ddb5ef8210bdd19a29c913e1 (Draft / code review only).

  • Dedicated exact-head GitHub Actions run #37944116264 SUCCESS. Node 22: 100 pass / 0 fail; Node 24: 100 pass / 0 fail; exact source/test obtained from pinned public GitHub raw paths at the PR-head SHA. Both jobs ran actual node --check and node --test tests/dispatch/l3-authorization.test.js.
  • M-040 Final Product Validation #37944116207 SUCCESS at the same head, but M-040 alone did not run the new D1 file.
  • Initial dedicated CI #37943862372 failed at actions/checkout, before any test: product HEAD has a .agent gitlink without resolvable .gitmodules URL; action cleanup hit fatal: No url found for submodule path '.agent' in .gitmodules. The revised dedicated workflow avoids executing code from the gitlink and fetches only D's exact two PR-head files (no checkout/submodule or credentials persisted), then runs the two Node versions. Treat the Gitlink/checkout compatibility as a separate A-owned infrastructure finding, not a D1 authorization test failure.

Evidence classification: D1_FOCUSED_PR_HEAD_UNIT_PASS (2 real CI runner versions) + M040_EXISTING_SUITE_PASS. This is not a full source checkout D1 integration test, formal architecture G0, actual GovernanceStore/Owner/Lease/fencing or real Host/effect-sink AUTH/E2E PASS. D1 deliberately returns execution_authorized:false and remains a fixture-only validator. Official AUTH-01..14 and L3-E2E cases remain NOT_RUN.

E next: independently inspect current exact head + CI logs + fixture limitations; review shared workflow change separately, verify no unintended escalation and report remaining P0/P1 blockers. Do not mark READY/merge/release/Dispatch based solely on these tests.

@Kucell Kucell left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E independent QA — PR #52 exact-head D1 CI evidence review (CODE_REVIEW_ONLY)

Review scope: product Draft PR #52 exact HEAD 2531cb2de2af8ae1ddb5ef8210bdd19a29c913e1. This is an independent source/CI evidence review, not an approval for integration, governance G0, live Dispatch, merger or release.

Source inspected: the review branch adds lib/dispatch/l3-authorization.js, tests/dispatch/l3-authorization.test.js, and A-owned shared CI workflow .github/workflows/v116-d-l3-auth-review.yml (the latter change is separately attributed to A/shared CI integration; D's fixture source/test remain unchanged). D validator only accepts injected snapshot fixtures; its positive outcome is SCOPE_MATCHED_FIXTURE_ONLY with execution_authorized:false and effect_permitted:false. Missing Decision/Waitpoint, malformed scopes and stale cached results are exercised as fixture checks only; no real canonical store read/Host/effect sink exists in this PR.

E independently verified original CI logs and script, not merely green badges:

  • Dedicated GitHub Actions run #37944116264 pull_request, head_sha=2531cb2de2af8ae1ddb5ef8210bdd19a29c913e1, completed SUCCESS.
  • Node 22 job #113865796756: explicit SOURCE_PR_HEAD=2531cb2..., actual node --check for both files and node --test tests/dispatch/l3-authorization.test.js; 100 tests / 100 pass / 0 fail, zero skipped/cancelled.
  • Node 24 job #113865797192: same pinned SHA and test command; 100 / 100 / 0 fail, zero skipped/cancelled.
  • The workflow obtains only both D1 files from raw.githubusercontent.com/Kucell/cortex-agent/${REVIEW_SHA} under a commit SHA; permissions: contents: read, no production Host or secrets, no checkout of unrelated repo/submodule.
  • The older M040 #37902661384 was a legitimate M040 success but did not run D1. That historical gap is closed for focused fixture CI only.

Open boundary / infrastructure issue: initial dedicated attempt #37943862372 failed before test execution at actions/checkout because pinned .agent gitlink lacks usable .gitmodules URL in that checkout mode. A's updated workflow bypasses checkout; it does not prove clean full-product + pinned-governance checkout or formal G0. Track separately; do not invent/overwrite gitlink. A is the CI/integration owner.

Required acceptance accounting:

  • D1_PR52_FOCUSED_FIXTURE_CI = PASS Node22 100/100 + Node24 100/100 on exact head (real GitHub Actions evidence).
  • FORMAL_G0 = NOT_VERIFIED, LIVE_OWNER_LEASE_FENCE = NOT_VERIFIED, CANONICAL_DECISION_WAITPOINT / HOST / SINK = NOT_VERIFIED.
  • Official AUTH-01..14, L3-E2E-01..08, SE-E2E-A..F: all NOT_RUN (0/28 accepted). Never convert 100 fixture cases into actual effect or E2E acceptance.
  • Draft / CODE_REVIEW_ONLY / DO_NOT_MERGE remains the correct state. Need real authoritative integration and distinct G1–G6 before merge/Runtime use.

Result: E_SOURCE_AND_EXACT_HEAD_CI_REVIEW_COMPLETE_FOR_D1_FIXTURE_SCOPE; NO_FORMAL_APPROVAL, NO_MERGE. No code, branch, governance state, approval object, Host or deployment was mutated by E.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant