Repository navigation
build(ci): drop Node 14, require Node 16+ minimum - #45
Merged
Merged
Conversation
The team-pack workflow has been failing on the Node 14 matrix entry since e89e567 introduced tests/team-pack/project-scope.test.js, which uses the node: protocol prefix (added in Node 16.0.0) for built-in module imports. Bump engines.node to >=16.0.0 to match actual code reality, and drop Node 14 from the team-pack matrix so CI no longer runs a runtime version the package itself does not support. Also aligns team-pack matrix with current CI conventions (16+ minimum, no EOL Node line). No behavior change for users on supported versions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
team-pack.ymlworkflow has been failing on thetest (14)matrix entry sincee89e567introducedtests/team-pack/project-scope.test.js, which uses thenode:protocol prefix for built-in module imports (added in Node 16.0.0).This was a pre-existing failure on
main(visible since 2026-09-11). It blocks every PR that touches the team-pack test surface, including #23 (M-043 legacy governance migration).Changes
package.json: bumpengines.nodefrom">=14.0.0"to">=16.0.0"to match actual code reality (Node 14 is EOL since April 2023 and the codebase already uses Node 16+ features throughout)..github/workflows/team-pack.yml: drop14from the matrix, leaving[18, 22]to align with the project minimum supported runtime.Why a separate PR
The user has explicitly asked that smooth-upgrade work (M-043 / #23) land as a separate PR. The Node 14 compatibility issue is a CI infrastructure concern, not a migration feature, so it stays in its own focused PR. This also keeps the M-043 diff reviewable as a single concern.
Verification
package.jsonparses cleanly and reportsengines.node = ">=16.0.0".tests/team-pack/project-scope.test.jspasses locally on Node 24 (v24.11.0), 12/12 assertions.bin/cli.jssyntax check passes.test (18)/test (22)matrix entries stay green.Risk
EBADENGINEwarnings onnpm install. This is the intended outcome and matches the package's actual code surface.Related
e89e567).