Skip to content

build(ci): drop Node 14, require Node 16+ minimum - #45

Merged
Kucell merged 1 commit into
mainfrom
codex/fix-node14-compat-20261008
Oct 8, 2026
Merged

Kucell merged 1 commit into
mainfrom
codex/fix-node14-compat-20261008

Conversation

@Kucell

@Kucell Kucell commented Oct 8, 2026

Copy link
Copy Markdown
Owner

Summary

The team-pack.yml workflow has been failing on the test (14) matrix entry since e89e567 introduced tests/team-pack/project-scope.test.js, which uses the node: protocol prefix for built-in module imports (added in Node 16.0.0).

This was a pre-existing failure on main (visible since 2026-09-11). It blocks every PR that touches the team-pack test surface, including #23 (M-043 legacy governance migration).

Changes

  • package.json: bump engines.node from ">=14.0.0" to ">=16.0.0" to match actual code reality (Node 14 is EOL since April 2023 and the codebase already uses Node 16+ features throughout).
  • .github/workflows/team-pack.yml: drop 14 from the matrix, leaving [18, 22] to align with the project minimum supported runtime.

Why a separate PR

The user has explicitly asked that smooth-upgrade work (M-043 / #23) land as a separate PR. The Node 14 compatibility issue is a CI infrastructure concern, not a migration feature, so it stays in its own focused PR. This also keeps the M-043 diff reviewable as a single concern.

Verification

  • package.json parses cleanly and reports engines.node = ">=16.0.0".
  • tests/team-pack/project-scope.test.js passes locally on Node 24 (v24.11.0), 12/12 assertions.
  • bin/cli.js syntax check passes.
  • Will rely on CI to confirm the new test (18) / test (22) matrix entries stay green.

Risk

  • Users pinned to Node 14 will see EBADENGINE warnings on npm install. This is the intended outcome and matches the package's actual code surface.
  • The team-pack matrix loses a runtime version the package never truly supported. No code path is removed; only the failing matrix entry is dropped.

Related

The team-pack workflow has been failing on the Node 14 matrix entry since
e89e567 introduced tests/team-pack/project-scope.test.js, which uses the
node: protocol prefix (added in Node 16.0.0) for built-in module imports.
Bump engines.node to >=16.0.0 to match actual code reality, and drop Node
14 from the team-pack matrix so CI no longer runs a runtime version the
package itself does not support.

Also aligns team-pack matrix with current CI conventions (16+ minimum,
no EOL Node line).  No behavior change for users on supported versions.
@Kucell
Kucell merged commit 3f2c45e into main Oct 8, 2026
6 checks passed
@Kucell
Kucell deleted the codex/fix-node14-compat-20261008 branch October 10, 2026 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant