Repository navigation
fix(update): protect legacy scripts without ownership proof - #43
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Protect scripts in legacy projects whose
.agent/.script-manifest.jsonis missing or was created by the old cold-start behavior.Problem
The first
updaterecorded an unknown existing script's own hash as its managed origin. A laterupdatecould then treat that custom script as an unchanged framework script and replace it.initon an existing project could make the same ownership claim. Cold-start dry runs also wrote a manifest.Changes
ownership_proof: template_match. Treat legacy entries without that proof as protected when their origin differs from the current template.reconcileScripts(..., apply: false)read-only and use its ownership classification in theupdate --dry-runreport.--force-scripts.Verification
node tests/security/scan.test.js: 17 checks passed.git diff --checkpassed.This PR addresses managed-script ownership only. Historical Decision and Waitpoint migration remains in M-043 / PR #23. Old projects still need read-only preflight, separate product and governance backups, and a trial upgrade before switching.