You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Add %v and %q options to format in CodeBuilder.buildLine and some handy indentation methods - #246
Added %v and %q options to format in CodeBuilder.buildLine. Why? When I implemented Rust's Reqwest target (I'll make the corresponding Pull Request after this one), I noticed the problem of escaping characters. For example, my chrome browser generates sec-ch-ua header, that contains quotes, and some of the targets do not escape them, which results in broken code. And also I'm using it in the mentioned Reqwest target.
Added indent, unindent and reindent methods to CodeBuilder, as it allows to control indentation more conveniently.
How do %v and %q options work?
Right from the comments I made to the new format function:
Wraps the util.format function and adds the %q and %v format options, where %q - escape tricky characters, like newline or quotes and %v - JSON-stringify-if-necessary
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution. 1 out of 2 committers have signed the CLA.
✅ uWynell ❌ eeWynell You have signed the CLA already but the status is still pending? Let us recheck it.
hey @uWynell! sorry that I didn't see this sooner, but in #248 we did a bit of a total overhaul and vastly simplified this stuff (in a slightly different way). I'm going to close this PR for now in part also because we removed the utils package usages from the entire package and won't be adding it back or expanding upon it.
Really appreciate your PR, truly, and hope to see more in the future! If I mixed something up please let me know!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
%vand%qoptions to format inCodeBuilder.buildLine. Why? When I implemented Rust's Reqwest target (I'll make the corresponding Pull Request after this one), I noticed the problem of escaping characters. For example, my chrome browser generatessec-ch-uaheader, that contains quotes, and some of the targets do not escape them, which results in broken code. And also I'm using it in the mentioned Reqwest target.indent,unindentandreindentmethods toCodeBuilder, as it allows to control indentation more conveniently.How do
%vand%qoptions work?Right from the comments I made to the new
formatfunction:Examples: