release_dir implicitly required, causes issues for projects without it #125

Activity

1. irby commented on Sep 2, 2025

   

   irby

   on Sep 2, 2025

   More actions

   Today I was bit by the release_project parameter defined as a non-required input (https://github.com/Keyfactor/actions/blob/main/.github/workflows/dotnet-build-and-release.yml#L20)

   In this workflow, https://github.com/Keyfactor/actions/blob/main/.github/workflows/dotnet-build-and-release.yml#L100, if this parameter is not set (empty) it will result in an Actions failure.

     [xml]$csproj = Get-Content ""
     $targetFrameworks = $csproj.Project.PropertyGroup.TargetFrameworks
     if ($null -eq $targetFrameworks) {
       $targetFrameworks = $csproj.Project.PropertyGroup.TargetFramework
     }
     echo "release_platforms: $targetFrameworks"
     echo "release_platforms=$targetFrameworks" | Out-File $env:GITHUB_ENV -Encoding utf8 -Append
     shell: C:\Program Files\PowerShell\7\pwsh.EXE -command ". '{0}'"
     env:
       DOTNET_ROOT: C:\Program Files\dotnet
       REPO_NAME: [project]
       SOLUTION_PATH: D:\a\...\[project].sln
       CREATE_RELEASE: True
       IS_PRE_RELEASE: True
   Get-Content: D:\a\_temp\86950a7a-0f73-4719-a26e-57124ecc67ea.ps1:2
   Line |
      2 |  [xml]$csproj = Get-Content ""
        |                             ~~
        | Cannot bind argument to parameter 'Path' because it is an empty string.