Repository navigation
Conversation
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is not a complete feature, but a proof of concept for discussion.
In recent projects we encountered two cases where workarounds were needed for the compiler backend: indicating invalid parameter configurations, and returning multiple objectives (time, energy).
There are workarounds for both, returning infinity for errors and running everything twice for time/energy.
In this branch I wrote a proof-of-concept for a more structured way of handling this. It works by passing a pointer to an ExtendedReturnValue object to the C function, which gets filled by the host code, and interpreted by kernel tuner.
It is intended to be fully optional, with the existing style of returning the time still working unchanged.
It is currently mostly functional, with some temporary hacks and breakage of the old "return time"-style, but it should be complete enough to paint a picture of this method and see if this something that would be valuable to add, and if it is worth the added complexity.