Repository navigation
Tests for passing arguments to and from Julia kernels - #407
Closed
benvanwerkhoven wants to merge 1 commit into
Closed
benvanwerkhoven wants to merge 1 commit into
benvanwerkhoven wants to merge 1 commit into
Conversation
Adds tests with a kernel that accumulates into its output for the first n elements only. They check that arrays and scalars are passed to and from the kernel correctly with run_kernel, that the user's arguments are not modified, and that output verification works and outputs are reset between configurations. Inputs and answers are tested both as numpy arrays and as Julia arrays. Also checks that a wrong answer fails verification.
|
fjwillemsen
added a commit
that referenced
this pull request
Nov 2, 2026
fjwillemsen
reviewed
Nov 3, 2026
fjwillemsen
left a comment
fjwillemsen
left a comment
Member
There was a problem hiding this comment.
These extended tests are useful to guarantee good compatibility moving forward. I've pulled this PR into the julia branch, slightly amended the tests and resolved a bug around scalar conversion. Following this, the full tests including these new tests ran successfully.
Collaborator
Author
|
Great! If you've pulled these into another branch, can this pull request be closed? |
Member
|
Yes, closing and will submit a pull request for the Julia branch soon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was afraid of breaking the Julia backend unintentionally at some point in the future, thus I wanted to add some more tests. In particular relating to how the arguments are passed in and when verifying kernel output. As I ran into some bits and pieces here and there that was added specifically for Julia while merging other stuff. So this is to make sure that Julia keeps working.