Skip to content

Breakage on Julia v1.0 #5

Open
Open

Description

@jishnub

https://github.com/JuliaMath/IntegerMathUtils.jl/pull/3/files#diff-28602f93a5d315a5d6dfd2d013de41a6b0bcbd3ed01c7ca21dca919edc4b78fbR13 seems to have broken this package on Julia v1.0, since the macro @ccall is not defined. Perhaps the support for v1.0 should be dropped if it isn't supported.

Activity

  1. oscardssmith commented on Jun 29, 2023

    @oscardssmith
    Member

    Good catch. I will bump support to 1.6 since I don't think many people are still using versions less than the LTS.

  2. jishnub commented on Jun 29, 2023

    @jishnub
    MemberAuthor

    I think it'll also be better to update the general registry compat bounds, to make Julia v1.0 use v0.1.0 of this package

  3. oscardssmith commented on Jun 29, 2023

    @oscardssmith
    Member

    I was just going to yank 0.1.1, but if there's a better way to do it, that would be great.

  4. jishnub commented on Jun 29, 2023

    @jishnub
    MemberAuthor

    Once v0.1.2 is tagged, I can make a PR to the registry

  5. devmotion commented on Jun 29, 2023

    @devmotion
    Member

    To avoid such problems in the future, IMO it would be good to add CI tests and in particular also test Julia 1.6. It seems currently no tests are run on Github?

    (I don't know anything about this package but somehow quite a few notifications showed up in my feed 😅)

  6. oscardssmith commented on Jun 29, 2023

    @oscardssmith
    Member

    yeah. I do need to get CI set up for this package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions