Repository navigation
Icon parity with javaabu/forms v2: eye, pencil, trash-2, check, … #21
Description
From javaabu/permissions (next-gen), whose role pages ship in both Blade and Inertia React.
javaabu/forms v2 bundles 30 Lucide icons for start-icon / end-icon (arrow-down, arrow-up, arrow-up-down, calendar, check, chevron-*, circle-alert, circle-check, circle-x, clock, download, ellipsis, external-link, eye, file, file-text, image, info, loader-circle, map-pin, pencil, plus, search, trash-2, triangle-alert, upload, x; see its docs/basic-usage/icons.md).
@javaabu/forms' IconName only has download, close, plus, error, chevron-up/down/left/right and chevrons-up-down, so this doesn't typecheck:
<LinkButton url={links.edit} color="secondary" size="sm" startIcon="pencil">Edit</LinkButton>
<Submit color="danger" size="sm" startIcon="trash-2">Delete</Submit>The Blade role pages use eye, pencil, trash-2 and check on their buttons; the React pages leave the icons out for now.
Suggested: accept the same names as Blade (IconName as the union of the bundled Lucide names, mapped in the Onu adapter), and list the difference in docs/parity.md until then.
Activity
Custom field hooks, useTableSelection, Blade icon names
n4ff4h commentedon Nov 5, 2026
Done in 204e616 on
next-gen(PR #19), CI green: https://github.com/Javaabu/react-forms/actions/runs/42055926515IconNamenow accepts Blade's 30 bundled Lucide names (eye,pencil,trash-2,check, …). Any other string is treated as icon-font classes, which render as<i class>as in Blade.closeanderrorstay as aliases. SostartIcon="pencil"andstartIcon="trash-2"now typecheck onButton,SubmitandLinkButton.scripts/icons.mjs.pencil→edit,trash-2→trash,x→close, …), soOnuProvider iconsoverrides apply.circle-alertandcircle-x, which Onu doesn't name, use the Lucide SVG.Iconcomponent (Blade's<x-forms::icon>), plusBUNDLED_ICONS,ICON_ALIASESandresolveIconName()for adapters.@javaabu/forms/testingchecks that every adapter draws them.docs/basic-usage/icons.md;docs/parity.mdnow listsIcon↔iconas ✅. Blade'siconsconfig stays Blade-only.The role pages can now use the same icons as the Blade ones.