Skip to content

Google Maps: a fallback Map ID until GOOGLE_MAPS_MAP_ID is set #37

Closed

Description

@n4ff4h

The demo site build reads GOOGLE_MAPS_API_KEY and GOOGLE_MAPS_MAP_ID. Until the Map ID secret is set, fall back so advanced markers still work, and centre the demos on the Javaabu office. Test the Google Maps adapter against the real API once the key is in.

Activity

  1. n4ff4h commented on Oct 14, 2026

    @n4ff4h
    CollaboratorAuthor

    The fallback is done in 8f2aa7c (merged in f14ecf9). An unset secret arrives as an empty string, so the Google adapter now treats an empty Map ID as none and uses DEMO_MAP_ID, which lets advanced markers work. Static map thumbnails leave it out.

    Still open:

    • Javaabu office coordinates. JAVAABU_OFFICE in examples/src/showcase/maps/_data.ts is central Malé until the real coordinates are filled in.
    • Setting the GOOGLE_MAPS_MAP_ID secret, then testing the adapter against the real API.

    Generated by Claude Code

  2. n4ff4h commented on Oct 15, 2026

    @n4ff4h
    CollaboratorAuthor

    The map demos now open on Javaabu's office (4.2239957591415855, 73.54706581849936), in b0a15d7. With the DEMO_MAP_ID fallback already in place, this is done. Javaabu will set the GOOGLE_MAPS_MAP_ID secret later; no code change is needed when it does.


    Generated by Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions