You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Test against javaabu/settings v2 (require-dev still pins ^1.8) #20
forms v2 no longer requires settings (thanks for #18), but require-dev still has "javaabu/settings": "^1.8" (and javaabu/helpers ^1.74, which also pins settings ^1.7), so forms' tests run against settings v1, and the suggest entry has no version.
settings v2 keeps get_setting() (what Support\Settings and Support\MimeTypes call), so nothing in forms' code needs to change. What I'd suggest:
require-dev: "javaabu/settings": "^2.0@dev" with a VCS repository https://github.com/n4ff4h/settings (until it's merged into Javaabu/settings and released), and drop javaabu/helpers from require-dev if the mime-type test can do without it (helpers v1 can't install next to settings v2).
suggest: "javaabu/settings": "Lets the per-page and map components read defaults from settings (^2.0)".
Low priority: apps aren't blocked, since it's dev-only.
Fixed on next-gen in b50462e (PR #16); CI is green on PHP 8.4/8.5 × Laravel 12/13 × lowest/stable.
I dropped both from require-dev rather than moving to settings v2. The tests never used settings itself, only get_setting(), and settings v2 requires javaabu/forms, so a dev dependency on it would be circular (and would pull in permissions, stencil and their VCS repos).
require-dev no longer has javaabu/settings or javaabu/helpers.
A get_setting() stand-in in tests/TestSupport/helpers.php (values from FakeSettings, cleared before each test) covers reading per_page, default_lat and max_*_file_size from settings. It returns null for unset keys, as settings does.
The file and image tests set forms.defaults.max_upload_file_size instead of settings v1's defaults.max_upload_file_size config key.
suggest: javaabu/settings "… (^2.0)". docs/requirements.md says settings v1 or v2 works, and that helpers v1 needs settings v1.
The CI check that composer show --tree --no-dev has neither package is unchanged, and MimeTypesTest now also asserts that neither is in require-dev.
Activity
Test without javaabu/settings and javaabu/helpers (#20)
n4ff4h commentedon Nov 5, 2026
Fixed on
next-genin b50462e (PR #16); CI is green on PHP 8.4/8.5 × Laravel 12/13 × lowest/stable.I dropped both from
require-devrather than moving to settings v2. The tests never used settings itself, onlyget_setting(), and settings v2 requiresjavaabu/forms, so a dev dependency on it would be circular (and would pull in permissions, stencil and their VCS repos).require-devno longer hasjavaabu/settingsorjavaabu/helpers.get_setting()stand-in intests/TestSupport/helpers.php(values fromFakeSettings, cleared before each test) covers readingper_page,default_latandmax_*_file_sizefrom settings. It returnsnullfor unset keys, as settings does.forms.defaults.max_upload_file_sizeinstead of settings v1'sdefaults.max_upload_file_sizeconfig key.suggest:javaabu/settings"… (^2.0)".docs/requirements.mdsays settings v1 or v2 works, and that helpers v1 needs settings v1.composer show --tree --no-devhas neither package is unchanged, andMimeTypesTestnow also asserts that neither is inrequire-dev.