Skip to content

Table with no-bulk renders nothing after the container #17

Closed

Description

@n4ff4h

From javaabu/exports v2 (n4ff4h/exports, next-gen), against forms next-gen 8ae5828.

<x-forms::table no-bulk> renders only the empty table-container div. The <table>, the headers and the rows are lost:

Blade::render('<x-forms::table model="exports" no-checkbox no-bulk><x-slot:headers><th>H</th></x-slot:headers><x-slot:rows><tr><td>ROW</td></tr></x-slot:rows></x-forms::table>');
// <div class="table-responsive …" data-slot="table-container">
//     </div>

Without no-bulk, the same markup renders the full table.

Likely cause: resources/views/onu/table.blade.php opens <x-forms::form> inside one @if(empty($no_bulk)) block and closes </x-forms::form> in a second one. Blade compiles a component's open and close tags as a pair. When the first block is skipped, everything up to the close tag becomes the form's slot and isn't output. Before 47fe718 the template checked $noBulk, which was never set, so the branch was always entered and the bug didn't show.

What I need: no-bulk (and no bulk-form slot) should render the table normally. Until then, exports leaves no-bulk off; that's harmless because it passes no bulk form.

Activity

  1. added
    next-genNext-gen Javaabu packages
    cross-packageRequested by or affecting another next-gen package
    on Nov 4, 2026
  2. n4ff4h commented on Nov 4, 2026

    @n4ff4h
    Author

    Fixed in cdc4bae on next-gen (CI green). The bulk form's <x-forms::form> open and close tags sat in two separate @if blocks, so with no-bulk the whole table compiled into a slot that was never output. The table markup is now a partial (table/table.blade.php in each framework), included either inside the bulk form or on its own. The bulk form also uses the slot's method now. Tests cover no-bulk without a slot, no-bulk with a bulk-form slot (no form rendered) and the normal bulk form, in both frameworks. exports can use no-bulk again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    cross-packageRequested by or affecting another next-gen packagenext-genNext-gen Javaabu packages

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions