Repository navigation
Sidechain spends are opt-in; cached chain state; 0.0.10 - #31
Merged
Merged
Conversation
…s cached; 0.0.10 - off until turned on, in settings or in the spend window when a site first asks (declining answers 'unsupported'); settings list the chains in use with their pinned signer and a Forget button; turning spends off forgets every chain; 0.0.9 pins carry over as turned on (src/sidestr/settings.js) - window.nostr.sidestr.enabled, read live from <html data-podkey-sidestr> which the content script mirrors from the setting - the explorer resumes from its saved state and the holders' asset view from its own, both keyed to the block hash at the saved height; a mismatch drops both and every block is checked again. sidestr:dreamlab: 5.9 s -> 0.3 s, identical view, 47 KB saved; the window says what it checked Co-Authored-By: jjohare <github@thedreamlab.uk>
…as focus Turning spends on signs nothing, so it takes the primary style rather than the danger-toned approve style Sign uses; the safe choice keeps the focus. Co-Authored-By: jjohare <github@thedreamlab.uk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sidechain spends become opt-in, and each chain's validated state is cached so spends open quickly. 0.0.10.
Opt-in
code: 'unsupported'.window.nostr.sidestr.enabled, read live from<html data-podkey-sidestr>, which the content script mirrors from the setting.signTransactionis present either way, so a site never hits a dead end. A page that forges the attribute only misleads itself.Cache
sidestr:dreamlab, a full check of all 545 blocks took 5.9 s and a resumed check 0.3 s, with an identical asset view. The saved state is 47 KB.Checks
npm testpasses 228/228, with new tests covering the settings, migration, forget and off, and an asset-view resume that must equal a full replay and refuse a mismatched save. Lint is clean.Spec text: sidestr/spec (PR to follow) adds
enabledand the opt-in behaviour to the browser-signer proposal.🤖 Generated by Claude Code