Repository navigation
Popup: a quiet version line on every screen, with the commit CI built - #30
Merged
Merged
Conversation
… built Every CI build of main shares the manifest version, so the version alone cannot tell two downloads apart. CI stamps build.json with the commit it built (the PR head on a pull request, not GitHub's temporary merge commit), and the popup shows 'v0.0.9 · 2cf8fe8' at the foot of every screen, the full commit and build time on hover. A source build has no build.json and shows the version alone. Co-Authored-By: jjohare <github@thedreamlab.uk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The popup now shows which build you have. This commit reached #28 after it had been squash-merged, so it comes here on its own, rebased on
main.v0.0.9 · 86e32bfat its foot, with the full commit and build time on hover.mainshares the manifest version, so CI stampsbuild.jsonwith the commit it built (the PR head on a pull request, not GitHub's temporary merge commit). A source build has nobuild.jsonand shows the version alone.Checked by rendering the built popup in Chrome at popup size.
npm testpasses 218/218 and lint is clean.🤖 Generated by Claude Code