Repository navigation
Phase 1: fix port/name inconsistencies, add --version - #2
Merged
Merged
Conversation
- Unify default port on 5444 across README and CLI (was: README 3000 / code 5444) - Replace 7 jssd references with jspod (help banner, examples, URLs, env var) - Add -v/--version flag reading from package.json - Remove broken --verbose example from production deploy section - Bump jspod to 0.0.8 A new user following the README literally now hits a working URL, sees the correct binary name in help output, and can query the version. Refs #1
29 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Phase 1 of #1 — eliminate first-run friction caused by jspod's own internal inconsistencies. A new user following the README literally now lands on a working URL with correct branding.
5444across README and CLI (README documented3000, code defaulted to5444→ dead URL for new users)jssdreferences inindex.js(help banner, examples, repo URLs,TOKEN_SECRETdefault) withjspod-v/--versionflag (reads frompackage.jsonso it stays in sync)jspod --verboseexample from production-deploy section (flag never existed)0.0.8Acceptance criteria (from #1 phase 1)
npx jspod --helpoutput matches what the README documentshttp://localhost:5444)grep -i 'jssd' .(excluding node_modules) returns nothing--versionflag addedTest plan
node index.js --version→jspod v0.0.8node index.js -v→jspod v0.0.8node index.js --helpshows correct binary name, port, and version flagnode index.js --boguserrors cleanly with usage hintnode index.js --port 9999 --no-authboots and shows correct URL in bannergrep -rn 'jssd' --include='*.js' --include='*.md' --include='*.json' .(excluding node_modules / lockfile) returns no matchesNot in scope
Phases 2-7 of #1 (demo-by-default, auto-open browser, seed content, visual assets, cross-repo, telemetry) — each will land as its own PR per the issue's "ship small" guidance.
Refs #1